-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google.rst #454
Update google.rst #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With regards to making updates to the example files, can we introduce a new contribution requirement to include some sort of verification?
Is there a way to verify these changes work? Screen shot, demo, or something else maybe? |
Without "openid", the "email" attribute is not returned: |
was the example broken before? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
https://developers.google.com/identity/protocols/oauth2/openid-connect?hl=en#scope-param
https://developers.google.com/identity/protocols/oauth2/scopes#oauth2